fix(sessions): add universal deduplication check in InMemorySessionService (#5723)#5727
Open
chriskinzel wants to merge 4 commits into
Open
fix(sessions): add universal deduplication check in InMemorySessionService (#5723)#5727chriskinzel wants to merge 4 commits into
chriskinzel wants to merge 4 commits into
Conversation
rohityan
added
the
services
rohityan
added
the
request clarification
Collaborator
|
Hi @chriskinzel , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors by running autoformat.sh |
rohityan
added
needs review
Collaborator
|
Hi @wyf7107 , can you please review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5723 by adding a universal deduplication check at the beginning of InMemorySessionService.append_event.